-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert - #879 and #768 #3521
Revert - #879 and #768 #3521
Conversation
…able_program_accounts()` (solana-labs#879)" This reverts commit 5fe30cb.
a0af9a3
to
62fd83a
Compare
svm/src/transaction_processor.rs
Outdated
@@ -286,12 +287,12 @@ impl<FG: ForkGraph> TransactionBatchProcessor<FG> { | |||
&validation_results, | |||
PROGRAM_OWNERS | |||
)); | |||
let native_loader = native_loader::id(); | |||
for builtin_program in self.builtin_program_ids.read().unwrap().iter() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to take this out of the timing measurement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably go in the measurement above instead. But should not really matter. I can move it anyway.
e3d1697
to
0ff3b76
Compare
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
…olana-labs#768)" This reverts commit e7617a1.
0ff3b76
to
064f77a
Compare
Sorry, forgot to run svm/tests/concurrent_tests.rs which is behind a cfg. So, needs to be re-approved. |
Revert - #879 and #768 (#3521) * Revert "Cleanup - Removes the owner form the result of `filter_executable_program_accounts()` (#879)" This reverts commit 5fe30cb. * Revert "Refactor - Remove `program_accounts_map` from account_loader (#768)" This reverts commit e7617a1. (cherry picked from commit 57bdb8e) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Problem
Summary of Changes
This reverts these commits: